Update functions.js subtitles by button turned out dead end #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so it sounds like the method might not even be of use as a backup? |
|
player.getSubtitlesUserSettings() is in my tests 100% reliable. player with no subtitles available doesnt posses any 'Subtitles User Settings' and returns null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2400 button was still fragile and breaking :(. The only bulletproof ways of learning if subtitles are available are
also
player.isSubtitlesOn()does work even if video has no subtitles, andplayer.toggleSubtitlesOn()is ignored in same case making both safe to call without checking.