Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update player.js unmangle #2221

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Update player.js unmangle #2221

merged 1 commit into from
Apr 29, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Apr 29, 2024

No description provided.

@ImprovedTube
Copy link
Member

😆😅
i find the first line semantically tidy. First checking if the feature is enabled, then all conditions

(Next to appreciating fewest symbols. Code is math.)

@raszpl
Copy link
Contributor Author

raszpl commented Apr 29, 2024

you are declaring variable deep in a comparison, you just made it unreadable :(

@ImprovedTube
Copy link
Member

cant risk such sad emoji

@ImprovedTube ImprovedTube merged commit b1e9fc4 into code-charity:master Apr 29, 2024
@raszpl raszpl deleted the patch-3 branch April 30, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants