Update satus.js include categories in search #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exciting!!! (sometimes i take pride answering only reading the title) |
..great to start! i mean 😅😏🥰 thanks for slowly inheriting https://github.com/code-charity/SATUS#roadmap |
|
#2201 prepared infrastructure for this change. With #2201 you can close search any time you want, and when you reopen it will remember last search query and scroll position. Now I need to figure out clever way of plumbing it together so clicking on 'button' in search will close it revealing whatever we clicked, and clicking Loupe icon will bring us back in the same search spot as before. |
|
#2201 takes over the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has side effects. While buttons are returned now, clicking them does nothing at first glance - thats because they are doing their thing under the Search results.
This is bad and shouldnt be merged :)