Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide video title on fullscreen #1848

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

asifurrahaman754
Copy link
Member

@asifurrahaman754 asifurrahaman754 commented Nov 22, 2023

Issue #1677

feature added in appearrance -> player -> hide video title in fullscreen

It will hide the video title when the video is fullscreen and the option is enabled. Currently, this feature works for all videos, not for a category of videos

Capture

@asifurrahaman754 asifurrahaman754 changed the title Add hide video title on fullscreen feature feat: hide video title on fullscreen feature Nov 22, 2023
@asifurrahaman754 asifurrahaman754 changed the title feat: hide video title on fullscreen feature feat: hide video title on fullscreen Nov 22, 2023
@ImprovedTube
Copy link
Member

🥰 Thanks!

@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 22, 2023

What about starting with if storage .. = true?

also adding optimization when switching off the feature (while our code runs billions of times, most features are switched on permanently.

@ImprovedTube ImprovedTube merged commit b7a153a into code-charity:master Nov 22, 2023
ImprovedTube added a commit that referenced this pull request Nov 23, 2023
ImprovedTube added a commit that referenced this pull request Nov 23, 2023
ImprovedTube added a commit that referenced this pull request Nov 23, 2023
ImprovedTube added a commit that referenced this pull request Nov 23, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 23, 2023

What about starting with if storage .. = true?

257db41

We only need to switch off most features based on user input (So less code runs billions of times. most features are switched on permanently and allow to "set&forget" ) (even if this time it matters less: can only be tested through enabling the ImprovedTube icon on Youtube: drag & drop)

ImprovedTube added a commit that referenced this pull request Nov 23, 2023
ImprovedTube added a commit that referenced this pull request Nov 23, 2023
@ImprovedTube
Copy link
Member

aaand it gets even shorter :D @asifurrahaman754

3e419ed

(this way the feedback when switching on/off the feature is automated in our script and including it with a shortcut was easy too)
(Didnt benchmark which is faster? - came up with this way when JS was still slower)

@asifurrahaman754 asifurrahaman754 deleted the hide-video-title branch November 24, 2023 14:34
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants