Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Add z-index for button tooltip. #2706

Closed
XP1 opened this issue Dec 4, 2024 · 0 comments · Fixed by #2707
Closed

🐞 Add z-index for button tooltip. #2706

XP1 opened this issue Dec 4, 2024 · 0 comments · Fixed by #2707
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@XP1
Copy link
Contributor

XP1 commented Dec 4, 2024

Bug Report:

  • Description: The z-index for ImprovedTube's button tooltip is missing.

ImprovedTube button tooltip

  • Steps to reproduce this: Put the metadata buttons onto the second row:
/* Expand metadata buttons. */
ytd-watch-metadata #above-the-fold > #top-row {
    display: block;
}

/* Adjust metadata buttons. */
ytd-watch-metadata #above-the-fold > #top-row #actions #menu > ytd-menu-renderer {
    justify-content: normal;
}
  • Since when?: Unknown
  • Browser: Chromium-based

YouTube's tooltip tp-yt-paper-tooltip element uses z-index: 1002;. I would suggest adding that to the .improvedtube-player-button:hover::after rule in /js&css/extension/www.youtube.com/styles.css:

https://github.com/code-charity/youtube/blob/master/js%26css/extension/www.youtube.com/styles.css#L676

/* Fix ImprovedTube tooltip. */
.improvedtube-player-button:hover::after {
    z-index: 1002;
}
@XP1 XP1 added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Dec 4, 2024
XP1 added a commit to XP1/ImprovedTube that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant