newest 4.3 build mousewheel scrolling doesn't work when scrolling down or up when not on video

[jeremy-hill]

Bug Report:

⚬ BUG: When using this addon, mousewheel when mouseovering the video adjusts volume by default, which still works. However, mousewheeling ANYWHERE in the window adjusts volume now, even when not mouseovering the video.

⚬ HOW: Start a video, move your mouse anywhere where the video is not, and mouseover. Volume will adjust, the page will not scroll.

⚬ EXPECTED (/preferred) behavior: The page scrolls.

/ ⚬ Context: Doesn't matter if you're in Default view or Theater view.

Setup:

⚬ ImprovedTube Version: 4.3
⚬ Browser: Google Chrome Version 111.0.5563.65 (Official Build) (64-bit)
⚬ Settings: (I'm not really comfortable with this; a lot of my watch history is in here.)
⚬ OS: Windows 10
⚬ Device: PC

[ImprovedTube]

hi! @jeremy-hill thats a nice feature. Funny thing: we don't have it (yet). Our extension does nothing by default, besides the 3 three extra buttons.

• feature is part of youtube enhancer & tweaks-for-youtube.

• thought of a customizable approach:
  BUG: scroll shortcuts in firefox & FEATURE REQUEST: 1. Shortcut requirement hover player optional (or other elements) 2. predefined scroll for volume option 3. multiple shortcuts for one action #862 &

• moreover :D mouseover (hover) any elemenet like <video> could be a condition for any (custom-)shortcuts in any extension! tweaks for videos/youtube (be it media or every day GUI )

[jeremy-hill]

Gosh maybe I'm on the wrong github! This is for *Improve YouTube!*🎧(for YouTube + Video), extension ID bnomihfieiccainjcjblhegjgglakjdd?

If so, I'm saying this settings:

applies everywhere on the page, not just when over the video -- you can't scroll down at all. Please let me know if I'm on the wrong github though!

[jeremy-hill]

Yeah I think I have the right place, as these guys (not me), who posted in the Chrome Web Store are also having the issue:

[Aweron]

I actually came here to ask about this bug/change as well. I believe I setup this feature manually after switching from a different extension that had that feature, and I assume @jeremy-hill might have as well a while ago, so they forgot that and didn't mention it. I think it's just a manual hotkey setting for volume. I would really like if it could be made how it was before, as it was practically the only reason I used the extension.

[ImprovedTube]

hi! @jeremy-hill ohhh 😆 sorry for my confusion! My bad

also,

theater
would you prefer the scroll-overwriting to happen trigger only on the video, not on the player background?

(then we are prepared just replacing the elements.player with elements.video here) (@MohamedLebda)
https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/a1fc43675c6842ee5dcb4a1a22981af60f6d5d73/content-scripts/website-context/youtube-features/shortcuts.js#L135-L145
(just a question of GUI.

we can get back the specific feature button named "scroll for volume, while mouse is on the video", as it was in old version 1.x ( @MohamedLebda )

(next to mouse over as a building block for any shortcut maybe 🤔)

[jovibor]

However, mousewheeling ANYWHERE in the window adjusts volume now, even when not mouseovering the video.

Confirmed. I have exactly same bug.

[ImprovedTube]

Hi @jovibor