Fees calculations don’t allow overflowing/underflowing

[c4-bot-10]

Lines of code

https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/tick.rs#L236-L245

Vulnerability details

Impact

update_position-related transactions may revert in some situations.

Vulnerability Details

In the get_fee_growth_inside function, the calculations of fee_growth_global_0, fee_growth_global_1, etc. don’t allow under- and overflowing. However, the respective calculations in Uniswap V3 are designed to underflow and overflow (for more information, refer to Uniswap/v3-core#573 issue and Jeiwan/uniswapv3-book#45). As a result, executing update_position can revert in some situations (such as test incr_position_fee_growth_tick), causing transaction reverts.

Tools Used

Manual analysis

Recommended Mitigation Steps

Use overflowing_sub instead of checked_sub.

Assessed type

Under/Overflow