Upgraded Q -> 2 from #167 [1728301859344]

[c4-judge]

Judge has assessed an item in Issue #167 as 2 risk. The relevant finding follows:

[LOW-5] Removal of liquidity also requires the pool to be enabled:

In LOC-687, lib.rs, it is said that liquidity removal from a position does not require the pool to be enabled:

https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/seawater/src/lib.rs#L687

    /// Requires token approvals to be set if adding liquidity. Requires the caller to be the
    /// position owner. Requires the pool to be enabled unless removing liquidity.

However, the function update_position() in pool.rs, which is called by update_position_internal() in lib.rs requires the pool to be enabled:

https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/seawater/src/pool.rs#L92

assert_or!(self.enabled.get(), Error::PoolDisabled);

Recommended Mitigation Steps:

Consider allowing removal of liquidity even when the pool is not enabled, that is, when delta is negative

[c4-judge]

alex-ppg marked the issue as duplicate of #31

[c4-judge]

alex-ppg marked the issue as partial-50