Upgraded Q -> 2 from #167 [1727128717282]

[c4-judge]

Judge has assessed an item in Issue #167 as 2 risk. The relevant finding follows:

[LOW-3] No function to set the fee_protocol of a pool:

Uniswap v3 has a function that let's the factory owner to set the protocol's fee denominator value for a pool. However, no such function exists in pool.rs. However, the pool storage contains the fee_protocol var:

https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/seawater/src/pool.rs#L31

fee_protocol: StorageU8,

Therefore, the protocol won't be able to collect fee on the swap operations that would take place.

Recommended Mitigation Steps:

Add a function that would let the admin set the fee_protocol variable.

[LOW-4] No use of seconds and tick_cumulative values of a tick:

The tick.rs contains the following in its storage:

https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/seawater/src/tick.rs#L54

    tick_cumulative_outside: StorageI64,
    seconds_per_liquidity_outside: StorageU160,
    seconds_outside: StorageU32,

However, these values are never set and used by the protocol. These values are basically maintained by uniswap v3 for other external contracts to use.

Recommended Mitigation Steps:

It is recommended to remove these storage vars if there are not to be used.

[c4-judge]

alex-ppg marked the issue as duplicate of #8

[c4-judge]

alex-ppg marked the issue as partial-50

[c4-judge]

alex-ppg marked the issue as partial-75

[c4-judge]

alex-ppg marked the issue as satisfactory