Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> 3 from #29 [1714596076809] #34

Closed
c4-judge opened this issue May 1, 2024 · 8 comments
Closed

Upgraded Q -> 3 from #29 [1714596076809] #34

c4-judge opened this issue May 1, 2024 · 8 comments
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly duplicate-5 unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@c4-judge
Copy link
Contributor

c4-judge commented May 1, 2024

Judge has assessed an item in Issue #29 as 3 risk. The relevant finding follows:

[L-02] In the liquidate function , the node wallet is not verified to be the same as the one of the trading pool
@c4-judge c4-judge added the 3 (High Risk) Assets can be stolen/lost/compromised directly label May 1, 2024
c4-judge added a commit that referenced this issue May 1, 2024
@c4-judge
Arabadzhiev issue #34 (File generated from upgraded finding by judge …
32521f6 
…alcueca)
@c4-judge
Copy link
Contributor Author

c4-judge commented May 1, 2024

alcueca marked the issue as duplicate of #15

@c4-judge c4-judge closed this as completed May 1, 2024
@c4-judge
Copy link
Contributor Author

c4-judge commented May 2, 2024

alcueca marked the issue as satisfactory

@c4-judge c4-judge added satisfactory satisfies C4 submission criteria; eligible for awards unsatisfactory does not satisfy C4 submission criteria; not eligible for awards and removed satisfactory satisfies C4 submission criteria; eligible for awards labels May 2, 2024
@c4-judge
Copy link
Contributor Author

c4-judge commented May 3, 2024

alcueca marked the issue as unsatisfactory:
Invalid

@Arabadzhiew
Copy link

This issue is a duplicate of #5 (same root cause).

@c4-judge
Copy link
Contributor Author

c4-judge commented May 3, 2024

alcueca marked the issue as not a duplicate

@c4-judge c4-judge reopened this May 3, 2024
@c4-judge c4-judge removed the unsatisfactory does not satisfy C4 submission criteria; not eligible for awards label May 3, 2024
@c4-judge
Copy link
Contributor Author

c4-judge commented May 3, 2024

alcueca marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label May 3, 2024
@c4-judge
Copy link
Contributor Author

c4-judge commented May 3, 2024

alcueca marked the issue as duplicate of #5

@c4-judge c4-judge closed this as completed May 3, 2024
@c4-judge
Copy link
Contributor Author

c4-judge commented May 8, 2024

alcueca marked the issue as unsatisfactory:
Invalid

@c4-judge c4-judge added unsatisfactory does not satisfy C4 submission criteria; not eligible for awards and removed satisfactory satisfies C4 submission criteria; eligible for awards labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly duplicate-5 unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arabadzhiew @c4-judge