Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #67

Open
c4-bot-6 opened this issue Mar 1, 2024 · 4 comments
Open

QA Report #67

c4-bot-6 opened this issue Mar 1, 2024 · 4 comments
Labels
bug Something isn't working grade-b Q-29 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@c4-bot-6
Copy link
Contributor

c4-bot-6 commented Mar 1, 2024

See the markdown file with the details of this report here.
@c4-bot-6 c4-bot-6 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Mar 1, 2024
c4-bot-3 added a commit that referenced this issue Mar 1, 2024
@c4-bot-3
Fassi_Security issue #67
04b104c
c4-bot-7 added a commit that referenced this issue Mar 1, 2024
@c4-bot-7
Fassi_Security data for issue #67
7f825b4
@MarioPoneder
Copy link

#69 #71

@c4-judge
Copy link
Contributor

MarioPoneder marked the issue as grade-b

@bronzepickaxe
Copy link

Hi @MarioPoneder,

Thank you for judging!

We would like you to reconsider the grade of our QA report. We feel that this is at least on par with QA Report 168. We have the same QA finding about the signatures not being canceled, but in addition to that, our report includes #71, which the Sponsor appreciated and deemed as useful and has not been found by anyone else.

Thanks!

@mcgrathcoutinho mcgrathcoutinho mentioned this issue Mar 16, 2024
Closed
@MarioPoneder
Copy link

Hi, thanks for your comment!

  1. & 2. are NC, 3., 4. & 5. are plain amount 0 zero checks which do not provide much value. But due to 69 and 71, grade-b is still justified.

@C4-Staff C4-Staff added the Q-15 label Mar 19, 2024
@C4-Staff C4-Staff added Q-29 and removed Q-15 labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-b Q-29 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MarioPoneder @c4-judge @C4-Staff @bronzepickaxe @c4-bot-6