Partial payment can't be made if a user borrows exactly minBorrow or a little bit above minBorrow

[c4-bot-10]

Lines of code

https://github.com/code-423n4/2023-12-ethereumcreditguild/blob/2376d9af792584e3d15ec9c32578daa33bb56b43/src/loan/LendingTerm.sol#L527-L532

Vulnerability details

Some lendingTerm requires a user to make partial payment by paying minPartialRepayPercent which might vary across terms. The borrowed Amount is deducted from the issuance and verified if greater than minBorrow , this condition will result in some users not being able to pay back the loan partially is the new borrowAmount is less than or equal to minBorrow

        require(
        borrowAmount - issuanceDecrease >
            ProfitManager(refs.profitManager).minBorrow(),
        "LendingTerm: below min borrow"
    );

Impact

User will not be able to pay the partial payment if the borrowAmount isn't significantly get than the minBorrow

Proof of Concept

        // check that enough CREDIT is borrowed
        require(
            borrowAmount >= ProfitManager(refs.profitManager).minBorrow(),
            "LendingTerm: borrow amount too low"
        );

When the borrower creates the debt the borrowAmount is checked if greater than or equal to the minBorrow in this case a user can borrow exactly the minBorrow amount .

However during partialRepay the borrowAmount after a user pays part is verified to be greater than minBorrow

 require(
            borrowAmount - issuanceDecrease >
                ProfitManager(refs.profitManager).minBorrow(),
            "LendingTerm: below min borrow"
        );

Making the repayment an issue for borrowers who borrowed little and potential issues for other huge borrowers who are required to pay partially in the long run.

Tools Used

Manual Review

Recommended Mitigation Steps

Change the > in the requt statement fo >= this will allow the users pay partially while the minBorrow is till pegged.

 require(
            borrowAmount - issuanceDecrease >=
                ProfitManager(refs.profitManager).minBorrow(),
            "LendingTerm: below min borrow"
        );

Assessed type

Context

[c4-pre-sort]

0xSorryNotSorry marked the issue as sufficient quality report

[c4-pre-sort]

0xSorryNotSorry marked the issue as duplicate of #1182

[c4-judge]

Trumpero changed the severity to QA (Quality Assurance)

[c4-judge]

Trumpero marked the issue as grade-b

[c4-judge]

Trumpero marked the issue as grade-c