Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> 2 from #332 [1706646042460] #1279

Closed
c4-judge opened this issue Jan 30, 2024 · 3 comments
Closed

Upgraded Q -> 2 from #332 [1706646042460] #1279

c4-judge opened this issue Jan 30, 2024 · 3 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate-1057 partial-50 Incomplete articulation of vulnerability; eligible for partial credit only (50%)

Comments

@c4-judge
Copy link
Contributor

Judge has assessed an item in Issue #332 as 2 risk. The relevant finding follows:

params.maxDelayBetweenPartialRepay should never be zero

In LendingTerm.partialRepayDelayPassed, the code makes it return false if maxDelayBetweenPartialRepay is set to 0, which stands to reason. However, due to this, that value will prevent anyone from calling an underwater loan, unless the entire gauge gets deprecated, which seems pretty drastic. We recommend never to allow this parameter to be zero, considering how easy it is to get bad debt and require the gauge to be deprecated.
@c4-judge c4-judge added the 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value label Jan 30, 2024
c4-judge added a commit that referenced this issue Jan 30, 2024
@c4-judge
0x70C9 issue #1279 (File generated from upgraded finding by judge Tru…
b81db71 
…mpero)
@c4-judge
Copy link
Contributor Author

Trumpero marked the issue as duplicate of #1057

@Trumpero
Copy link

This issue should receive only 50% partial credit due to its lack of quality.

@c4-judge c4-judge added the partial-50 Incomplete articulation of vulnerability; eligible for partial credit only (50%) label Jan 30, 2024
@c4-judge
Copy link
Contributor Author

Trumpero marked the issue as partial-50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate-1057 partial-50 Incomplete articulation of vulnerability; eligible for partial credit only (50%)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c4-judge @Trumpero