QA Report

[c4-bot-1]

See the markdown file with the details of this report here.

[0xSorryNotSorry]

A Market Can Not Be Deployed For A Token > 18 Decimals -> dup of #957

[c4-pre-sort]

0xSorryNotSorry marked the issue as sufficient quality report

[Trumpero]

Potential Loss of Assets in emergencyAction Function due to Unchecked msg.value
-> L

Unspent Native Coin gets rejected on calling emergencyAction function
-> L

Use of assert Instead of require in Smart Contract
-> bot finding (N-12)

CEI Should Be Followed
-> bot finding (L-19)

Add A Min Check On setGaugeWeightTolerance
-> L

surplusBufferSplit/guildSplit/othersSplit Might Round Down To 0
-> L

A Market Can Not Be Deployed For A Token > 18 Decimals
-> info (dup of #957)

Have A Minimum Value For maxDelayBetweenPartialRepay
-> info

Missing 0 Address/Value Checks (Missed By The Bots)
-> L

Incorrect Comment
-> NC

Handle The 0 surplusBuffer Case In The If Clause
-> info

Sanity Checks
-> NC

Make Sure CREDIT Can Not Be Redeemed To The SimplePSM Itself
-> info

[Trumpero]

+L from #1144

[c4-judge]

Trumpero marked the issue as grade-a