QA Report

[c4-bot-6]

See the markdown file with the details of this report here.

[c4-pre-sort]

0xSorryNotSorry marked the issue as sufficient quality report

[Trumpero]

[L-01]: bot report duplication (N-52) -> invalid
[L-02]: bot report duplication (D-47) -> invalid
[N-01]: NC
[N-02]: gas purpose - OOS
[N-03]: missing instances of bot reports-> NC
[N-04]: code style -> NC
[N-05]: code style -> NC
[N-06]: typo -> NC
[N-07]: code style -> NC
[N-08]: the returned params are already explain in comments -> invalid

[c4-judge]

Trumpero marked the issue as grade-c

[thenua3bhai]

Hi @Trumpero Thanks for judging and listing all the insights about each finding it is really helpful as feedback.
I just want to say that in this QA report about
[L-01] and [L-02] findings name can be similar to bot but here in my report it covered different instances which were missed by bot and analyzer . I have also written a Note : Missed by bot report below each finding which was covered in bot but some instances missed in bot report so I only reported those instances. Since it will add value to the protocol and also fixing bot instances won't fix missed ones. So Please re-consider them if you find this appropriate
And [N-08] I reported this since function using both named return variables and also explicitly returning variables also so this can be confusing in reading that function whose value will be returned finally. So I reported that also.
Thanks

[Trumpero]

@thenua3bhai
As per C4's judge guideline, trivial instances of bot reports shouldn't be considered separately unless they are complex cases
Additionally, this report has insufficient points to be a grade-b, even when L-01, L-02 and N-08 are accepted