Hardcoded Min_stake of 1e18 doesn’t incentivize staking expensive tokens

[c4-bot-7]

Lines of code

https://github.com/code-423n4/2023-12-ethereumcreditguild/blob/2376d9af792584e3d15ec9c32578daa33bb56b43/src/loan/SurplusGuildMinter.sol#L26

Vulnerability details

Impact

Each CREDIT Token holder (gUSDC, gWETH, gWBTC, etc.) can stake them and start voting in a gauge. However, there's a minimum staking amount (MIN_STAKE) of 1e18. This means that for certain markets, staking will be more expensive compared to others because of this fixed minimum stake requirement.

Proof of Concept

For instance, in the case of gUSDC, users looking to stake will need to provide approximately 1 USDC (based on creditMultiplier). On the other hand, for gWBTC, they would need to stake around 1 BTC ($42,000 at the time of writing). This could discourage users from staking in such terms.

contract SurplusGuildMinter is CoreRef {
    /// @notice minimum number of CREDIT to stake
    uint256 public constant MIN_STAKE = 1e18;

....

Tools Used

Manual Review

Recommended Mitigation Steps

Include the MIN_STAKE value in the constructor, making it dependent on the Credit Token for that specific term.

Assessed type

Context

[c4-pre-sort]

0xSorryNotSorry marked the issue as sufficient quality report

[c4-pre-sort]

0xSorryNotSorry marked the issue as duplicate of #597

[c4-judge]

Trumpero changed the severity to QA (Quality Assurance)

[c4-judge]

Trumpero marked the issue as grade-b

[c4-judge]

Trumpero marked the issue as grade-a