Vulnerability: Using 0 as a Minimum Amount Allowed in AMMs can Cause Loss of Funds. / Contract: TokenisableRange / Function: claimFee

[code423n4]

Lines of code

https://github.com/GoodEntry-io/ge/blob/8a2686b14114edbd1ec523d79304ed678cc2e915/contracts/TokenisableRange.sol#L194-L201

Vulnerability details

Impact

No slippage protection on call to uniswap increase Liquidity function.

Proof of Concept

The amount0Min, amount1Min in the uniswap increaseLiquidity function are being set to 0, there is no slippage protection, so you are allowing to receive 0 tokens back without reverting the tx.

(uint128 newLiquidity, uint256 added0, uint256 added1) = 
   POS_MGR.increaseLiquidity(INonfungiblePositionManager.IncreaseLiquidityParams({
          tokenId: tokenId,
          amount0Desired: fee0,
          amount1Desired: fee1,
          amount0Min: 0,
          amount1Min: 0,
          deadline: block.timestamp
   })

Uniswap recommends using these parameters as slippage protection in production:
https://docs.uniswap.org/contracts/v3/guides/providing-liquidity/increase-liquidity

Tools Used

Manual Code Review.

Recommended Mitigation Steps

Add slippage protection to the function.

Assessed type

Uniswap

[c4-pre-sort]

141345 marked the issue as duplicate of #78

[c4-pre-sort]

141345 marked the issue as duplicate of #260

[c4-judge]

gzeon-c4 marked the issue as unsatisfactory:
Insufficient proof

[c4-judge]

gzeon-c4 changed the severity to QA (Quality Assurance)