In depositFsGlp() function AMOUNT should be checked with caller or msg.sender wallet balance using REQUIRE statement .

[code423n4]

Lines of code

https://github.com/code-423n4/2022-11-redactedcartel/blob/03b71a8d395c02324cb9fdaf92401357da5b19d1/src/PirexGmx.sol#L422-L465

Vulnerability details

Impact

Its possible attacker can call depositFsGlp() function recursively without having any fsGLP Token . Attacker can block the depositFsGlp() function inactive or Denial-of-Service (DoS) . Attacker can create flooding the target with traffic. Attacker can create artificial traffic for depositFsGlp() function.

Proof of Concept

2022-11-redactedcartel/src/PirexGmx.sol

   function depositFsGlp(uint256 amount, address receiver)
    external
    whenNotPaused
    nonReentrant
    returns (
        uint256,
        uint256,
        uint256
    )
   {
    if (amount == 0) revert ZeroAmount();
    if (receiver == address(0)) revert ZeroAddress();

    // Transfer the caller's fsGLP (unstaked for the user, staked for this contract)
    stakedGlp.transferFrom(msg.sender, address(this), amount);

    // Get the pxGLP amounts for the receiver and the protocol (fees)
    (uint256 postFeeAmount, uint256 feeAmount) = _computeAssetAmounts(
        Fees.Deposit,
        amount
    );
   // Mint pxGLP for the receiver (excludes fees)
    pxGlp.mint(receiver, postFeeAmount);

    // Mint pxGLP for fee distribution contract
    if (feeAmount != 0) {
        pxGlp.mint(address(pirexFees), feeAmount);
    }

    emit DepositGlp(
        msg.sender,
        receiver,
        address(stakedGlp),
        0,
        0,
        0,
        amount,
        postFeeAmount,
        feeAmount
    );

    return (amount, postFeeAmount, feeAmount);
    }

Solution:

           require(stakedGlp.balanceOf(msg.sender)>amount, " Not enough fsGLP In your wallet");

The above line should be added before the stakedGlp.safeTransferFrom call . Need to make sure msg.sender balance is greater than amount .

Manual finding with vscode

Recommended Mitigation Steps

Can use require statements to make sure the MSG.SENDER balance

[Picodes]

Why would it lead to a DoS ?

[c4-judge]

Picodes marked the issue as unsatisfactory:
Insufficient proof