New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #497

Open

code423n4 opened this issue Sep 19, 2022 · 1 comment

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented Sep 19, 2022

See the markdown file with the details of this report here.

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          rokinot issue #497

b700e78

code423n4 added a commit that referenced this issue


          rokinot data for issue #497

5c25d07

Collaborator

HickupHH3 commented Nov 8, 2022

Surprisingly about 3.8k gas saved minimally. Unique find too! Example of some test gas diffs:

testControllerZeroAddress() (gas: -22863 (-0.131%)) 
testAllMarketsCreation() (gas: -114315 (-0.132%)) 
testVaultMarketEpochDoesNotExist() (gas: -11434 (-0.134%)) 
testFailMarketEpochExists() (gas: -3813 (-0.134%)) 
testEpochEndMustBeAfterBegin() (gas: -3813 (-0.140%)) 
testVaultAddressNotController() (gas: -3813 (-0.140%)) 
testFeeMoreThan() (gas: -3813 (-0.140%))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment