Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"> 0" is less efficient than "!= 0" for unsigned integers #24

Open
code423n4 opened this issue Dec 6, 2021 · 2 comments
Open

"> 0" is less efficient than "!= 0" for unsigned integers #24

code423n4 opened this issue Dec 6, 2021 · 2 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

ye0lde

Vulnerability details

Impact

Gas savings

Proof of Concept

"> 0" is used in the following location(s):

https://github.com/maple-labs/debt-locker/blob/81f55907db7b23d27e839b9f9f73282184ed4744/contracts/DebtLocker.sol#L312

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Change "> 0" to "!=0" for small gas savings.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 6, 2021
code423n4 added a commit that referenced this issue Dec 6, 2021
@code423n4
ye0lde issue #24
ee7d42f
@deluca-mike
Copy link
Collaborator

Good catch.

@deluca-mike deluca-mike added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 8, 2021
@deluca-mike deluca-mike mentioned this issue Dec 8, 2021
Closed
This was referenced Dec 9, 2021
Closed
Merged
@pauliax
Copy link
Collaborator

pauliax commented Dec 15, 2021

Valid optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pauliax @deluca-mike @code423n4