Merge pull request #1 from cocoonspace/chore/tests

add tests

fsm.go

@@ -1,9 +1,5 @@
 package fsm
 
-import (
-	"log"
-)
-
 // Event is the event type.
 // You can define your own values as
 //	const (
@@ -114,7 +110,6 @@ func On(e Event) Option {
 func Dst(s State) Option {
 	return func(t *transition) {
 		t.actions = append(t.actions, func(fsm *FSM) {
-			log.Println("[fsm] changing state from", fsm.current, "to", s)
 			fsm.current = s
 		})
 	}
@@ -183,15 +178,15 @@ func (f *FSM) Current() State {
 // true is returned if a transition is applied.
 func (f *FSM) Event(e Event) bool {
 	for i := range f.transitions {
-		if res := f.transitions[i].match(e, f.times, f); res != resultNOK {
+		if res := f.transitions[i].match(e, f.times+1, f); res != resultNOK {
 			if res == resultOK {
 				f.transitions[i].apply(f)
 			}
 			if i == f.previous {
 				f.times++
 			} else {
 				f.previous = i
-				f.times = 1
+				f.times = 0
 			}
 			return res == resultOK
 		}

fsm_test.go

@@ -0,0 +1,115 @@
+package fsm_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/cocoonspace/fsm"
+)
+
+const (
+	StateFoo fsm.State = iota
+	StateBar
+)
+
+const (
+	EventFoo fsm.Event = iota
+)
+
+func TestFSM(t *testing.T) {
+	f := fsm.New(StateFoo)
+	f.Transition(
+		fsm.On(EventFoo), fsm.Src(StateFoo),
+		fsm.Dst(StateBar),
+	)
+	res := f.Event(EventFoo)
+	if !res {
+		t.Error("Event returned false")
+	}
+	if f.Current() != StateBar {
+		t.Error("Bad destination state")
+	}
+}
+
+func TestCheck(t *testing.T) {
+	check := false
+	f := fsm.New(StateFoo)
+	f.Transition(
+		fsm.On(EventFoo), fsm.Src(StateFoo), fsm.Check(func() bool {
+			return check
+		}),
+		fsm.Dst(StateBar),
+	)
+	res := f.Event(EventFoo)
+	if res || f.Current() == StateBar {
+		t.Error("Transition should not happen because of Check")
+	}
+	check = true
+	res = f.Event(EventFoo)
+	if !res && f.Current() != StateBar {
+		t.Error("Transition should happen because of Check")
+	}
+}
+
+func ExampleCheck() {
+	f := fsm.New(StateFoo)
+	f.Transition(
+		fsm.On(EventFoo), fsm.Src(StateFoo), fsm.Check(func() bool {
+			return true
+		}),
+		fsm.Dst(StateBar),
+	)
+}
+
+func TestCall(t *testing.T) {
+	call := false
+	f := fsm.New(StateFoo)
+	f.Transition(
+		fsm.On(EventFoo), fsm.Src(StateFoo),
+		fsm.Call(func() {
+			call = true
+		}),
+	)
+	_ = f.Event(EventFoo)
+	if !call {
+		t.Error("Call should have been called")
+	}
+}
+
+func ExampleCall() {
+	f := fsm.New(StateFoo)
+	f.Transition(
+		fsm.On(EventFoo), fsm.Src(StateFoo),
+		fsm.Dst(StateBar), fsm.Call(func() {
+			fmt.Println("Call called")
+		}),
+	)
+}
+
+func TestTimes(t *testing.T) {
+	f := fsm.New(StateFoo)
+	f.Transition(
+		fsm.On(EventFoo), fsm.Src(StateFoo), fsm.Times(2),
+		fsm.Dst(StateBar),
+	)
+
+	res := f.Event(EventFoo)
+	if res || f.Current() == StateBar {
+		t.Error("Transition should not happen the first time")
+	}
+	res = f.Event(EventFoo) // transition to StateBar
+	if !res || f.Current() != StateBar {
+		t.Error("Transition should happen the second time")
+	}
+}
+
+func ExampleTimes() {
+	f := fsm.New(StateFoo)
+	f.Transition(
+		fsm.On(EventFoo), fsm.Src(StateFoo), fsm.Times(2),
+		fsm.Dst(StateBar),
+	)
+
+	_ = f.Event(EventFoo) // no transition
+	_ = f.Event(EventFoo) // transition to StateBar
+}