support mdns command through adb server with server-status

[JinkeJ]

No description provided.

[cocool97]

Thanks for the PR, will have a look at it asap !

[cocool97]

I had a look at the code and it looks good to me, I just made a few changes to it. Can you try and validate that nothing broke ? I removed the connect_with_envs() method and added a start_server() method that can take environment variable if needed.

For the varint parsing, couldn't we use a crate like this one and therefore remove this parser from adb_client ?

[JinkeJ]

The structure of server status is protobuf. You can replace the function with a crate.

[JinkeJ]

https://cs.android.com/android/platform/superproject/main/+/main:packages/modules/adb/proto/adb_host.proto;l=64?q=AdbServerStatus&sq=

[cocool97]

Is everything still working as expected with my modifications ?

I can't test it as my server does not support mdns and server-status..

[JinkeJ]

It seems that "start_server" runs twice if we run mdns_force_openscreen_backend.
Furthermore, ServerStatus fmt function should keep output same as adb, that is only writeln when usb_backend_forced or mdns_backend_forced is true.

[JinkeJ]

Any update?

[cocool97]

Hey, sorry for the delay !

I looked at your code, the only thing missing is adding a mdns check subcommand to adb_cli in order to provide the same functionalities as the official binary.

Can you handle it ? I'll merge it afterwards

[JinkeJ]

running start_server twice causes the stuck of starting new process, because when the first process haven't lifted up, the second process will try to start the server again.

[cocool97]

Would you mind having a look at it ? I'm afraid I won't have time in the next few days..

[JinkeJ]

I will have a try, but might need to define a new function or corrupt current existing function

[cocool97]

No problem, I'm planning on releasing a v2.1 with mdns

[JinkeJ]

@cocool97 Please resolve the conflict with main branch because I didn't pull the mdns branch to my local.

[JinkeJ]

mdns check, mdns devices, reconnect, reconnect offline, tcpip, usb, forwardremoveall, reverseremoveall, server-status

Those features are added in these commits.

[cocool97]

Thanks, I'll rebase it asap

[cocool97]

Double start_server is now fixed ?

[JinkeJ]

Yes, I removed start_server, because connect will start too.