Feature/y337 185173625 update for queue appts #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigpaul
reviewed
Jun 12, 2023
craigpaul
reviewed
Jun 15, 2023
src/models/client.ts
Outdated
| export interface ClientAttributes { | ||
| attributes?: object; | ||
| type: string; | ||
| receive_sms?: boolean; |
There was a problem hiding this comment.
This seems really out of place based on the convention this API follows. Is this a mistake?
craigpaul
reviewed
Jun 15, 2023
src/models/client.ts
Outdated
| }; | ||
|
|
||
| if (this.attributes.receive_sms) { | ||
| parameters.receive_sms = this.receiveSms; |
There was a problem hiding this comment.
This doesn't seem right. You're never setting this.receiveSms from what I can see (so it probably doesn't need to exist)
craigpaul
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to book queue appointments to the open api.
Motivation and context
now that appointments and queue appointments can be created from the client view, it makes sense for both to use this.
How has this been tested?
I linked this into core locally and then made use of it on the CV, and booked some queue appointments. (https://bitbucket.org/coconutcalendar/coconut-calendar/branch/feature/y337-185173625-open-api-js-queue-appts)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!