Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-536: Added recaptcha token as an optional parameter #48

Conversation

CodyAntcliffeCoconut
Copy link
Contributor

@CodyAntcliffeCoconut CodyAntcliffeCoconut commented Jun 27, 2022

Description

Change updates the Appointments API to allow for an optional Recaptcha Token parameter

Motivation and context

This will allow the backend to perform a recaptcha check against the request

If it fixes an open issue, please link to the issue here (if you write fixes #num
or closes #num, the issue will be automatically closed when the pull is accepted.)

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@craigpaul craigpaul marked this pull request as draft June 27, 2022 18:55
@craigpaul craigpaul marked this pull request as ready for review June 29, 2022 15:12
Copy link
Contributor

@craigpaul craigpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update the README with some information about this new method and some sort of caveat about it being reliant on a specific feature, etc.

src/resources/appointment.ts Outdated Show resolved Hide resolved
src/resources/appointment.ts Outdated Show resolved Hide resolved
@craigpaul craigpaul merged commit 10aa641 into coconutcalendar:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants