Add skip meeting link generation for appointments #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new appointment filter to skip the meeting link generation for appointments that are done over a video call. This will allow the user to create an appointment that is to be done via video call to skip the meeting link generation at the moment of creation.
Motivation and context
The change is required when we are experiencing issues with the video platform that is blocking our appointment creation. We want the ability to bypass the video platform issue so we can let users create appointments. Video links can be generated at a later time when the issue has been resolved.
How has this been tested?
I have included two new tests to the set of appointment tests. They are focused on testing the new appointment filter
withoutMeetingLink
. The test cases are:withoutMeetingLink
without any arguments. The default value of the parameter is true.withoutMeetingLink
with a single argument value of false.I have also updated two tests:
skip_meeting_link_generation
property to the meta parameters.skip_meeting_link_generation
property to the meta parameters.Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!