Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip meeting link generation for appointments #36

Conversation

jasonchucoconut
Copy link
Contributor

Description

This pull request adds a new appointment filter to skip the meeting link generation for appointments that are done over a video call. This will allow the user to create an appointment that is to be done via video call to skip the meeting link generation at the moment of creation.

Motivation and context

The change is required when we are experiencing issues with the video platform that is blocking our appointment creation. We want the ability to bypass the video platform issue so we can let users create appointments. Video links can be generated at a later time when the issue has been resolved.

How has this been tested?

I have included two new tests to the set of appointment tests. They are focused on testing the new appointment filter withoutMeetingLink. The test cases are:

  • Using the withoutMeetingLink without any arguments. The default value of the parameter is true.
  • Using the withoutMeetingLink with a single argument value of false.

I have also updated two tests:

  • "Can book an appointment with all available parameters".
    • Added the skip_meeting_link_generation property to the meta parameters.
  • "Can reschedule an appointment with all available parameters".
    • Added the skip_meeting_link_generation property to the meta parameters.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

…lude a skip_meeting_link_generation meta property to both appointment and reschedule parameters
…ip the meeting link generation when booking or rescheduling an appointment
@craigpaul craigpaul merged commit 77b0112 into coconutcalendar:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants