Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows setting remaining UTM parameters on request to book appointment #10

Conversation

willik
Copy link
Contributor

@willik willik commented Nov 3, 2019

Description

Allows the campaign, content, medium, and term UTM (Urchin Tracking Module) parameters to be set on the request to book an appointment.

Motivation and context

It can be useful to know where an appointment originated from. Having support for the remaining UTM parameters allows the full context of where an appointment originated from to be recorded.

How has this been tested?

Adds tests to your existing files.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@codecov-io
Copy link

codecov-io commented Nov 3, 2019

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines         698    718   +20     
  Branches       92     98    +6     
=====================================
+ Hits          698    718   +20
Impacted Files Coverage Δ
src/resources/appointment.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3438c46...5aa4c73. Read the comment docs.

@craigpaul craigpaul merged commit 59df845 into coconutcalendar:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants