Converts filter output to match expected query string for questions

coconutcalendar · Nov 30, 2018 · 9d975f4 · 9d975f4
1 parent 839d9dd
commit 9d975f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/resources/question.test.ts b/src/resources/question.test.ts
@@ -94,9 +94,7 @@ it('can get questions with additional parameters', async () => {
   expect(mockAxios.get).toHaveBeenCalledTimes(1);
   expect(mockAxios.get).toHaveBeenCalledWith('questions', {
     params: {
-      filters: {
-        service: 3,
-      },
+      'filter[service]': 3,
       limit: 5,
       page: 1,
       sort: 'created',

diff --git a/src/resources/question.ts b/src/resources/question.ts
@@ -1,5 +1,6 @@
 import { AxiosInstance } from 'axios';
 
+import { combine } from '../helpers/filters';
 import { Filterable, Pageable } from '../index';
 
 export interface QuestionFilter {
@@ -37,10 +38,10 @@ export default class Question implements QuestionResource {
 
   public async get(): Promise<any> {
     const parameters = this.params();
-    const params: Filterable<QuestionParameters> = {};
+    let params: Filterable<QuestionParameters> = {};
 
     if (Object.keys(parameters).length) {
-      params.filters = parameters;
+      params = combine(params, parameters);
     }
 
     if (this.limit) {