Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed cockroach subprocess; added Windows connection string parsing #4

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Removed cockroach subprocess; added Windows connection string parsing #4

merged 2 commits into from
Aug 30, 2021

Conversation

ericharmeling
Copy link
Contributor

Fixes #3

@ericharmeling
Copy link
Contributor Author

FYI, I have not tested this on Windows 😬

RichardJCai
RichardJCai approved these changes Aug 23, 2021
View reviewed changes
Copy link

@RichardJCai RichardJCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would add some comments about why the branches are needed (which OS is being used) so it's clear why the code is there for people trying out the demo

@ericharmeling ericharmeling mentioned this pull request Aug 24, 2021
Merged
@ericharmeling ericharmeling merged commit d491ac1 into main Aug 30, 2021
@ericharmeling ericharmeling deleted the windows-support branch September 9, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardJCai RichardJCai RichardJCai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The connection string isn't parsed correctly in Windows PowerShell
2 participants
@ericharmeling @RichardJCai