Revert snap_refresh_nanos feature (#5269) #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Our daily stress tests are failing after this feature. Reverting temporarily until we figure the reason for test failures. Pull Request resolved: facebook#5269 Differential Revision: D15151285 Pulled By: maysamyabandeh fbshipit-source-id: e4002b99690a97df30d4b4b58bf0f61e9591bc6e
|
running a bunch of repro attempts, will report whether any inconsistencies are found. |
petermattis
approved these changes
Sep 18, 2019
|
Right. Trying to remember to write that before you ask. Next time... |
|
Ack. I’m just being overly cautious this late in the release cycle. |
|
OK on cockroach master with this patch import seems to work: |
|
the test failures are unrelated (timeouts downloading dependencies). |
ajkr
added a commit
to ajkr/cockroach
that referenced
this pull request
Sep 18, 2019
Picks up cockroachdb/rocksdb#56. Release justification: This feature can cause a corruption where keys deleted by range tombstones reappear (see cockroachdb#38772 and cockroachdb#40213), so it's important we revert it. Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Sep 19, 2019
40899: c-deps: bump rocksdb to revert compaction snapshot refresh r=ajkr a=ajkr Picks up cockroachdb/rocksdb#56. Release justification: This feature can cause a corruption where keys deleted by range tombstones reappear (see #38772 and #40213), so it's important we revert it. Release note: None Co-authored-by: Andrew Kryczka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our daily stress tests are failing after this feature. Reverting temporarily until we figure the reason for test failures.
Pull Request resolved: facebook#5269
Differential Revision: D15151285
Pulled By: maysamyabandeh
fbshipit-source-id: e4002b99690a97df30d4b4b58bf0f61e9591bc6e
This change is