[2.1 backport] table: Always check key ordering when inserting to an SST #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent an out-of-order SSTable insertion from ever happening, this change updates BlockBasedTableBuilder::Add to always assert on key ordering being maintained at the insertion point, rather than only running with debug builds. When an out-of-order key insertion is detected, the status is set to Corrupted to prevent the BlockBasedTable from being written.
petermattis
approved these changes
Sep 11, 2019
|
@petermattis I've been relying on travis to do that - |
|
Thanks for the review! Gonna put out the cockroach PRs on the |
ajkr
added a commit
to ajkr/cockroach
that referenced
this pull request
Sep 12, 2019
Picks up cockroachdb/rocksdb#48 and cockroachdb/rocksdb#51. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46 .
To prevent an out-of-order SSTable insertion from ever happening, this
change updates BlockBasedTableBuilder::Add to always assert on key
ordering being maintained at the insertion point, rather than only
running with debug builds. When an out-of-order key insertion is
detected, the status is set to Corrupted to prevent the BlockBasedTable
from being written.
This change is