crdbutil: fix user table scan query #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfansharif
force-pushed
the
200325.scaledata-user-table
branch
from
9622526 to
a0dfaa2
Compare
SHOW USERS was implemented as a view on top of |
irfansharif
force-pushed
the
200325.scaledata-user-table
branch
from
a0dfaa2 to
781454c
Compare
Nice, done. |
Informs recent failures on #44066, #43284, #45645, #43273, #43839, #41528. cockroachdb/cockroach#45827 broke the query to retrieve users from the database, it was previously expecting one column, and needs to be updated to accept three. We now use `SELECT username FROM system.users` instead.
irfansharif
force-pushed
the
200325.scaledata-user-table
branch
from
781454c to
7e1e38b
Compare
nvanbenschoten
approved these changes
Mar 31, 2020
This was referenced Apr 2, 2020
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs recent failures on cockroachdb/cockroach#44066, cockroachdb/cockroach#43284, cockroachdb/cockroach#45645, cockroachdb/cockroach#43273, cockroachdb/cockroach#43839, cockroachdb/cockroach#41528.
cockroachdb/cockroach#45827 broke the query to
retrieve users from the database, it was previously expecting one column,
and needs to be updated to accept three.
Previous to #45827 the column name was
user_name(it's notusername), so the binary built off LATEST is not suitable forroachtests run on v19.2 and below. I'm not sure how to construct a query
that would work across the two versions, we'll add a patch to previous
release branches to use a fixed SHA from this repo.