Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sstable: change an out-of-bounds error into an assertion #3562

Merged
merged 1 commit into from
Apr 28, 2024
Merged

sstable: change an out-of-bounds error into an assertion #3562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sstable/value_block.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,8 +934,8 @@ func (r *valueBlockReader) getBlockHandle(blockNum uint32) (BlockHandle, error)
int(r.vbih.blockNumByteLength + r.vbih.blockOffsetByteLength + r.vbih.blockLengthByteLength)
offsetInIndex := indexEntryLen * int(blockNum)
if len(r.vbiBlock) < offsetInIndex+indexEntryLen {
return BlockHandle{}, errors.Errorf(
"cannot read at offset %d and length %d from block of length %d",
return BlockHandle{}, base.AssertionFailedf(
"index entry out of bounds: offset %d length %d block length %d",
offsetInIndex, indexEntryLen, len(r.vbiBlock))
}
b := r.vbiBlock[offsetInIndex : offsetInIndex+indexEntryLen]
Expand Down
Loading