-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: add go 1.16 CI #1166
travis: add go 1.16 CI #1166
Conversation
This adds go 1.16 to the TravisCI build/test matrix.
CI is really slow now :/ I wonder if it's time to switch to GitHub Actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @rail)
.travis.yml, line 26 at r1 (raw file):
os: linux script: make test generate - name: "go1.15.x-linux-race"
I think we can remove this configuration, as well as the other go-1.15.x-linux-*
variants, and go-1.15.x-windows
, and go-1.15.x-freebsd
. Leaving these configurations around tends to just slow down CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @petermattis and @rail)
.travis.yml, line 26 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
I think we can remove this configuration, as well as the other
go-1.15.x-linux-*
variants, andgo-1.15.x-windows
, andgo-1.15.x-freebsd
. Leaving these configurations around tends to just slow down CI.
I'll create a separate issue for this, maybe using GitHub Actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
.travis.yml, line 26 at r1 (raw file):
Previously, rail (Rail Aliiev) wrote…
I'll create a separate issue for this, maybe using GitHub Actions.
Historically, we've only ever supported testing on the current version and one config of the previous version. I'm fine with that level of testing. No need to expand it dramatically. See #983 for the go1.15 upgrade PR.
I see. Creating a PR now. |
This adds go 1.16 to the TravisCI build/test matrix.