Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: add go 1.16 CI #1166

Merged
merged 1 commit into from
Jun 28, 2021
Merged

travis: add go 1.16 CI #1166

merged 1 commit into from
Jun 28, 2021

Conversation

rail
Copy link
Member

@rail rail commented Jun 15, 2021

This adds go 1.16 to the TravisCI build/test matrix.

This adds go 1.16 to the TravisCI build/test matrix.
@rail rail self-assigned this Jun 15, 2021
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail rail requested a review from petermattis June 15, 2021 21:12
@rail
Copy link
Member Author

rail commented Jun 15, 2021

CI is really slow now :/ I wonder if it's time to switch to GitHub Actions.

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @rail)


.travis.yml, line 26 at r1 (raw file):

      os: linux
      script: make test generate
    - name: "go1.15.x-linux-race"

I think we can remove this configuration, as well as the other go-1.15.x-linux-* variants, and go-1.15.x-windows, and go-1.15.x-freebsd. Leaving these configurations around tends to just slow down CI.

Copy link
Member Author

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @petermattis and @rail)


.travis.yml, line 26 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

I think we can remove this configuration, as well as the other go-1.15.x-linux-* variants, and go-1.15.x-windows, and go-1.15.x-freebsd. Leaving these configurations around tends to just slow down CI.

I'll create a separate issue for this, maybe using GitHub Actions.

@rail rail merged commit c37f580 into cockroachdb:master Jun 28, 2021
Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


.travis.yml, line 26 at r1 (raw file):

Previously, rail (Rail Aliiev) wrote…

I'll create a separate issue for this, maybe using GitHub Actions.

Historically, we've only ever supported testing on the current version and one config of the previous version. I'm fine with that level of testing. No need to expand it dramatically. See #983 for the go1.15 upgrade PR.

@rail
Copy link
Member Author

rail commented Jun 28, 2021

I see. Creating a PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants