Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip TestDjango due to v2.1 failures #83

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

irfansharif
Copy link
Contributor

TestDjango fails on v2.1. Skipping the test while #82 is resolved.

TestDjango fails on v2.1. Skipping the test while
#82 is resolved.
@irfansharif irfansharif requested a review from rohany November 4, 2019 22:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rohany
Copy link
Contributor

rohany commented Nov 4, 2019

I would prefer instead if there was a way to disable this test if we are actually running against 2.1 or less. Does TC export an environment variable or something with the branch it built cockroach against?

@irfansharif
Copy link
Contributor Author

Not sure, @jordanlewis is our resident TC expert.

I would prefer instead if there was a way to disable this test if we are actually running against 2.1 or less

I don't think that knowledge should exist in this repo. cockroachdb/cockroach#42083 seems the more appropriate measure anyway.

@jordanlewis
Copy link
Member

TC does export a branch variable (I think $TC_BUILD_BRANCH). But I agree that we should be pinning this repo in the main cockroach repo.

I think we might want to just delete this repo and move it into cockroachdb/cockroach instead.

@irfansharif
Copy link
Contributor Author

Thoughts about this PR? I'll drop it if we're pinning examples-orms/folding into cockroachdb/cockroach (which will need to be backported?), but the recent few backports to release-v2.1 ran into this TestDjango failure and needed manual intervention to skip the github check (something I don't (nor most others) have admin access to do so).

@rohany
Copy link
Contributor

rohany commented Nov 5, 2019

If this is impacting a lot of your work then we can merge it and reenable the test once we pin a version on TeamCity

@irfansharif
Copy link
Contributor Author

Sounds good, thanks! (I wouldn't say a lot of my work but I mean, it does affect all backports to release-v2.1, which is a supported major version and does look kind of active: https://github.com/cockroachdb/cockroach/commits/release-2.1. Also looks like TestDjango was re-enabled as recently as #80, so merging on principle 🤞)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants