-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs custom 404 page and reword messaging #8415
Conversation
c1a1495
to
29208ec
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @yingzhuchin!
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @anagio, @jseldess, @lnhsingh, and @luciaaaaaaa)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I agree that it makes sense to push this one live
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @anagio, @lnhsingh, and @luciaaaaaaa)
Wondering if we want to add the 'Return to home' button, as a way for the user to have a clear action to take from here. Otherwise, lgtm! |
I think since the search bar, sidebar, and top navigation bar are all still accessible on the 404 page, the user should be good on what to do next. My two cents! |
I'll merge this for now since I'm shifting focus, but we can add any additional asks to #8082 and pick up from there! |
Fixes #4908 and #8076.
The custom 404 image is a stretch goal so I haven't attempted it with this PR.
Please preview the new 404 page here: https://deploy-preview-8415--cockroachdb-docs.netlify.app/docs/stable/404.html
You will not be able to see the page above by going to a broken link via preview site, because the way Netlify redirects, it will send you from a preview broken link to the 404 page in production. But you can use the Netlify preview site to verify that broken links are being redirected to the 404 page in production, which is an improvement over current behavior (see #4908).
I think this is one PR that we should make live immediately instead of waiting for all style updates. This is because the current 404 functionality is broken (see #4908), so we are essentially fixing a bug that affects users today.