Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for "transaction deadline exceeded" error, again #4676

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Add docs for "transaction deadline exceeded" error, again #4676

merged 1 commit into from
Apr 22, 2019

Conversation

rmloveland
Copy link
Contributor

(Still) fixes #4552.

Original discussion in #4667 . This change fixes a technical error I introduced while copy-editing some text of that PR.

Summary of changes (is still):

  • Update 'Common Errors' page with:

    • the retry error message

    • a recommendation that the user add retries to their app

    • a description of the state that leads to such errors (kindly
      contributed by Andrei Matei)

    • also spruced up the txn restart section intro with some links to
      reference docs on how txns work in CockroachDB for the curious.

@rmloveland
Add docs for "transaction deadline exceeded" error
ed42e2f 
Fixes #4552.

Summary of changes:

- Update 'Common Errors' page with:

  - the retry error message

  - a recommendation that the user add retries to their app

  - a description of the state that leads to such errors (kindly
    contributed by Andrei Matei)

  - also spruced up the txn restart section intro with some links to
    reference docs on how txns work in CockroachDB for the curious.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ed42e2f8003a8397e2832d41436d1071faf7603b/

Edited pages:

@rmloveland rmloveland requested a review from andreimatei April 22, 2019 21:12
@rmloveland
Copy link
Contributor Author

Trying again Andrei! Apologies for the earlier mixup. This PR should incorporate your text describing the error with a few of the edits of the less technical parts from @lhirata from #4667

@andreimatei
Copy link
Contributor

LGTM thanks!

@rmloveland rmloveland merged commit 20140d1 into master Apr 22, 2019
@rmloveland rmloveland deleted the 20190408-transaction-deadline-exceeded-retriable branch April 22, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreimatei andreimatei Awaiting requested review from andreimatei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage,kv: make transaction deadline exceeded errors retriable
3 participants
@rmloveland @cockroach-teamcity @andreimatei