Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted UI Updates #4597

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Assorted UI Updates #4597

merged 2 commits into from
Mar 28, 2019

Conversation

Amruta-Ranade
Copy link
Contributor

@Amruta-Ranade Amruta-Ranade commented Mar 28, 2019

Closes #4076 #4588

Summary:

@lhirata Thanks for the CDC screenshots 🙏

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@Amruta-Ranade Amruta-Ranade changed the title Assorted ui updates Assorted UI Updates Mar 28, 2019
Copy link

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: - this looks great, thank you!

@Amruta-Ranade Amruta-Ranade requested a review from jseldess March 28, 2019 20:20
Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:. Thanks, @Amruta-Ranada.

I just realized that we don't link to the CDC dashboard from the CDC docs. Mind looking into that while you're at it?

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @jseldess and @piyush-singh)

Copy link

@piyush-singh piyush-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 2 stale)

@Amruta-Ranade
Copy link
Contributor Author

@jseldess About the link to the CDC dashboard from the docs, @lhirata is handling that in #4403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants