-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added enable_implicit_transaction_for_batch_statements to v22.2 release notes #15836
Added enable_implicit_transaction_for_batch_statements to v22.2 release notes #15836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two changes and this should be good.
- Removed the byte string parameter in the `crdb_internal.schedule_sql_stats_compaction` function. [#82560][#82560] | ||
- Changed the default value of the `enable_implicit_transaction_for_batch_statements` to `true`. This means that a [batch of statements](../v22.2/transactions.html#batched-statements) sent in one string separated by semicolons is treated as an implicit transaction. [#76834](#76834) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the bottom of the following two files, can you add the following line?
[#76834]: https://github.com/cockroachdb/cockroach/pull/76834
- _includes/releases/v22.2/v22.2.0-alpha.1.md
- _includes/releases/v22.2/v22.2.0.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't see a place to put it in the _includes/releases/v22.2/v22.2.0.md file
ce55234
to
62caf6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another change.
- Removed the byte string parameter in the `crdb_internal.schedule_sql_stats_compaction` function. [#82560][#82560] | ||
- Changed the default value of the `enable_implicit_transaction_for_batch_statements` to `true`. This means that a [batch of statements](../v22.2/transactions.html#batched-statements) sent in one string separated by semicolons is treated as an implicit transaction. [#76834](#76834) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Changed the default value of the `enable_implicit_transaction_for_batch_statements` to `true`. This means that a [batch of statements](../v22.2/transactions.html#batched-statements) sent in one string separated by semicolons is treated as an implicit transaction. [#76834](#76834) | |
- Changed the default value of the `enable_implicit_transaction_for_batch_statements` to `true`. This means that a [batch of statements](../v22.2/transactions.html#batched-statements) sent in one string separated by semicolons is treated as an implicit transaction. [#76834][#76834] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, nice catch
62caf6f
to
79c5ec0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rafiss !
✅ Netlify PreviewBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
thanks for the reviews! |
References cockroachdb/cockroach#76834
See also DOC-6417