Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enable_implicit_transaction_for_batch_statements to v22.2 release notes #15836

Merged

Conversation

rafiss
Copy link
Contributor

@rafiss rafiss commented Dec 15, 2022

Copy link
Contributor

@nickvigilante nickvigilante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two changes and this should be good.

- Removed the byte string parameter in the `crdb_internal.schedule_sql_stats_compaction` function. [#82560][#82560]
- Changed the default value of the `enable_implicit_transaction_for_batch_statements` to `true`. This means that a [batch of statements](../v22.2/transactions.html#batched-statements) sent in one string separated by semicolons is treated as an implicit transaction. [#76834](#76834)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the bottom of the following two files, can you add the following line?

[#76834]: https://github.com/cockroachdb/cockroach/pull/76834
  • _includes/releases/v22.2/v22.2.0-alpha.1.md
  • _includes/releases/v22.2/v22.2.0.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't see a place to put it in the _includes/releases/v22.2/v22.2.0.md file

@rafiss rafiss force-pushed the fix-batch-stmt-release-note branch from ce55234 to 62caf6f Compare December 15, 2022 18:32
@rafiss rafiss requested a review from nickvigilante December 15, 2022 18:32
Copy link
Contributor

@nickvigilante nickvigilante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another change.

- Removed the byte string parameter in the `crdb_internal.schedule_sql_stats_compaction` function. [#82560][#82560]
- Changed the default value of the `enable_implicit_transaction_for_batch_statements` to `true`. This means that a [batch of statements](../v22.2/transactions.html#batched-statements) sent in one string separated by semicolons is treated as an implicit transaction. [#76834](#76834)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Changed the default value of the `enable_implicit_transaction_for_batch_statements` to `true`. This means that a [batch of statements](../v22.2/transactions.html#batched-statements) sent in one string separated by semicolons is treated as an implicit transaction. [#76834](#76834)
- Changed the default value of the `enable_implicit_transaction_for_batch_statements` to `true`. This means that a [batch of statements](../v22.2/transactions.html#batched-statements) sent in one string separated by semicolons is treated as an implicit transaction. [#76834][#76834]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, nice catch

@rafiss rafiss force-pushed the fix-batch-stmt-release-note branch from 62caf6f to 79c5ec0 Compare December 15, 2022 19:00
@rafiss rafiss requested a review from nickvigilante December 15, 2022 19:01
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rafiss !

@netlify
Copy link

netlify bot commented Dec 15, 2022

Netlify Preview

Built without sensitive environment variables

Name Link
🔨 Latest commit 79c5ec0
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/639b6ee356cd400008227e17
😎 Deploy Preview https://deploy-preview-15836--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rafiss
Copy link
Contributor Author

rafiss commented Dec 15, 2022

thanks for the reviews!

@nickvigilante nickvigilante merged commit 73df950 into cockroachdb:master Dec 15, 2022
ashleykwtam pushed a commit to ashleykwtam/cockroachdbdocs that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants