Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DROP OWNED BY #15094

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add DROP OWNED BY #15094

merged 1 commit into from
Dec 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 14, 2022

DOC-4770
DOC-5465 Depends on system privileges.
Blocks #15298

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

Files changed:

@netlify
Copy link

netlify bot commented Sep 14, 2022

Netlify Preview

Name Link
🔨 Latest commit d2a2b3b
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6321f8be52f6ab00095427b0
😎 Deploy Preview https://deploy-preview-15094--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Netlify Preview

Name Link
🔨 Latest commit 2b78214
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6321f9e312af6a00087a3ed1
😎 Deploy Preview https://deploy-preview-15094--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Netlify Preview

Name Link
🔨 Latest commit 6670fde
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6390f70bebbc2500092e355d
😎 Deploy Preview https://deploy-preview-15094--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost ghost self-requested a review September 14, 2022 16:06
@rmloveland
Copy link
Contributor

@chengxiong-ruan mind giving this another look? taking this over since Stephanie left the co a while back. Added some examples as well

@rafiss added you to review for the DOC-5465 piece

Copy link

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @stbof)

@rmloveland
Copy link
Contributor

NB. this PR will wait for #15715 to go in and then rebase/modify atop that one per this convo

(There should be no substantial technical content changes to this PR as part of that process tho)

Fixes DOC-4770
Fixes DOC-5465
Updated to include changes from DOC-5810, DOC-5811

Summary of changes:

- Add `DROP OWNED BY` docs page, with usage examples

  - .. and a link to the above from the 'SQL Statements' page

- Add information about a known limitation w.r.t. `DROP OWNED BY` and
  synthetic privileges

- Add information about a known limitation w.r.t. `DROP OWNED BY` not
  dropping user-defined functions (UDFs)

- NB. Both of the above now appear using the same text on the `DROP
  OWNED BY` and 'Known Limitations' pages via an include
@rmloveland
Copy link
Contributor

@ianjevans this is RFAL from a docs review POV now. The latest changes should all be "docs review only"-level changes in the sense that they shuffle around some things that have already had technical review either in this PR or in #15715

@rmloveland rmloveland merged commit 66f0418 into master Dec 8, 2022
@rmloveland rmloveland deleted the DOC-4770 branch December 8, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants