Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: declare node ready while decommissioning #6589

Closed
jseldess opened this issue Feb 19, 2020 · 1 comment · Fixed by #6825
Closed

server: declare node ready while decommissioning #6589

jseldess opened this issue Feb 19, 2020 · 1 comment · Fixed by #6825
Assignees
@jseldess
Labels
C-product-change P-1 High priority; must be done this release
Milestone
20.1

Comments

@jseldess
Copy link
Contributor

PR: cockroachdb/cockroach#43889

From release notes:

A node no longer declares itself unready through the /health?ready=1 endpoint while in the process of decommissioning. It continues to declare itself unready while draining. [#43889][#43889] {% comment %}doc{% endcomment %}
@jseldess jseldess added this to the 20.1 milestone Feb 19, 2020
@jseldess jseldess added P-1 High priority; must be done this release A-ops labels Feb 19, 2020
@jseldess
Copy link
Contributor Author

@taroface, I can take this one.

@jseldess jseldess assigned jseldess and unassigned taroface Mar 13, 2020
jseldess added a commit that referenced this issue Mar 13, 2020
@jseldess
Node considered ready until draining
14d2bc5 
Update health endpoint doc to clarify that a node is considered
unready when transferring leases and replicas, not before.

Fixes #6589.
@jseldess jseldess mentioned this issue Mar 13, 2020
Merged
jseldess added a commit that referenced this issue Mar 13, 2020
@jseldess
Node considered ready until draining
f816a7a 
Update health endpoint doc to clarify that a node is considered
unready when transferring leases and replicas, not before.

Fixes #6589.
jseldess added a commit that referenced this issue Mar 13, 2020
@jseldess
Decommissioned nodes are considered ready
b3af1ea 
Update health endpoint doc to clarify that a node is considered
unready when it can no longer accept new SQL connectsions, for
example, when shutting down. This excludes decomissioning since
a decommissioned node, although absent of data, can still serve
as a SQL gateway.

Fixes #6589.
jseldess added a commit that referenced this issue Mar 23, 2020
@jseldess
Decommissioned nodes are considered ready
cbbc04d 
Update health endpoint doc to clarify that a node is considered
unready when it can no longer accept new SQL connectsions, for
example, when shutting down. This excludes decomissioning since
a decommissioned node, although absent of data, can still serve
as a SQL gateway.

Also clarify that decommissioning does not cause a node to stop
accepting SQL connections.

Fixes #6589.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jseldess jseldess

Labels
C-product-change P-1 High priority; must be done this release
Projects
None yet
Milestone
20.1
Development

Successfully merging a pull request may close this issue.

Decommissioned nodes are considered ready cockroachdb/docs
2 participants
@taroface @jseldess