Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: async validation of foreign keys in ADD CONSTRAINT #4891

Open
jseldess opened this issue Jun 6, 2019 · 4 comments
Open

sql: async validation of foreign keys in ADD CONSTRAINT #4891

jseldess opened this issue Jun 6, 2019 · 4 comments
Assignees
@rmloveland
Labels
C-product-change no-issue-activity P-2 Normal priority; secondary task

Comments

@jseldess
Copy link
Contributor

jseldess commented Jun 6, 2019 •
edited by exalate-issue-sync bot
Loading

Jesse Seldess (jseldess) commented:

PR: cockroachdb/cockroach#37433

From release notes:

Foreign keys that are added to an existing table using ALTER TABLE will now be validated for existing rows, with improved performance compared to running ADD CONSTRAINT followed by VALIDATE CONSTRAINT previously. [#37433][#37433] {% comment %}doc{% endcomment %}

Jira Issue: DOC-279
@jseldess jseldess added this to the 19.2 milestone Jun 6, 2019
@jseldess jseldess added the P-1 High priority; must be done this release label Jun 6, 2019
jseldess added a commit that referenced this issue Oct 25, 2019
@jseldess
Document auto-validation of foreign keys
688e8b4 
Fixes #4891.
@jseldess
Copy link
Contributor Author

I'll take this one, @rmloveland.

@jseldess jseldess assigned jseldess and unassigned rmloveland Oct 25, 2019
@jseldess jseldess mentioned this issue Oct 25, 2019
Closed
@rmloveland
Copy link
Contributor

Thanks @jseldess !

jseldess added a commit that referenced this issue Oct 28, 2019
@jseldess
Document auto-validation of foreign keys
14e68c9 
Fixes #4891.
RaduBerinde pushed a commit that referenced this issue Dec 10, 2019
@jseldess @RaduBerinde
Document auto-validation of foreign keys
cda3ce4 
Fixes #4891.
Fixes #5187.
RaduBerinde pushed a commit that referenced this issue Dec 10, 2019
@jseldess @RaduBerinde
Document auto-validation of foreign keys
6d4f05c 
Fixes #4891.
Fixes #5187.
RaduBerinde pushed a commit that referenced this issue Dec 11, 2019
@jseldess @RaduBerinde
Document auto-validation of foreign keys
40c3ae0 
Fixes #4891.
Fixes #5187.
@jseldess
Copy link
Contributor Author

@ericharmeling, I don't think I'll get this over the finish line so reassigning to you. Feel free to take over the open PR or start fresh.

@jseldess jseldess assigned ericharmeling and unassigned jseldess Nov 23, 2020
@jseldess jseldess removed this from the 19.2 milestone May 25, 2021
@ericharmeling ericharmeling added P-2 Normal priority; secondary task and removed P-1 High priority; must be done this release labels Aug 26, 2021
@jseldess jseldess removed the G-sql label Jan 18, 2022
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
C-product-change no-issue-activity P-2 Normal priority; secondary task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document auto-validation of foreign keys cockroachdb/docs
3 participants
@rmloveland @jseldess @ericharmeling