Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify jdbc code samples #4621

Closed
jseldess opened this issue Apr 3, 2019 · 1 comment · Fixed by #4855
Closed

Simplify jdbc code samples #4621

jseldess opened this issue Apr 3, 2019 · 1 comment · Fixed by #4855
Assignees
@rmloveland
Labels
O-sales-eng Internal source: Sales Engineering P-1 High priority; must be done this release
Milestone
19.2

Comments

@jseldess
Copy link
Contributor

jseldess commented Apr 3, 2019

As discussed with @timveil, @awoods187, and @rmloveland, we should simplify our JDBC code samples (e.g., use fewer classes) so as to provide an easier, more intuitive point-of-entry for Java developers.
@jseldess jseldess added C-docs-project O-sales-eng Internal source: Sales Engineering P-1 High priority; must be done this release labels Apr 3, 2019
@jseldess jseldess added this to the 19.1 milestone Apr 3, 2019
@jseldess jseldess mentioned this issue Apr 3, 2019
Closed
@jseldess jseldess modified the milestones: 19.1, 19.2 Apr 30, 2019
@jseldess
Copy link
Contributor Author

Moving to 19.2.

@jseldess jseldess mentioned this issue May 15, 2019
Closed
rmloveland added a commit that referenced this issue May 30, 2019
@rmloveland
[WIP] Simplify JDBC code sample
70ecb33 
Fixes #4621, #3578, #4399.

Summary of changes:

- Update 'Build a Java App with CockroachDB' to use the Java DAO pattern

- Add a 'Recommended Practices' section that includes information about
  IMPORT, recommended batch size, and the JDBC INSERT rewriting flag

TODO:

- Update "secure" code sample to use certs.  Not worth doing yet until
  this code is reviewed by someone with Java expertise and updated to
  match good style, etc.  Once that is done, the secure code sample in
  this PR will be updated with the necessary cert munging.
@rmloveland rmloveland mentioned this issue May 30, 2019
Merged
rmloveland added a commit that referenced this issue Jun 6, 2019
@rmloveland
Simplify JDBC code sample
e3fcc9e 
Fixes #4621, #3578, #4399.

Summary of changes:

- Update 'Build a Java App with CockroachDB' to use:

  - the Java DAO pattern

  - JDBC

  - code for automatically retrying in case of txn retry errors

  - an example of fast bulk insertion using JDBC batching

- Add a 'Recommended Practices' section that includes information about
  IMPORT, recommended batch size, and the JDBC INSERT rewriting flag
rmloveland added a commit that referenced this issue Jun 17, 2019
@rmloveland
Simplify JDBC code sample
b5dd9ce 
Fixes #4621, #3578, #4399.

Summary of changes:

- Update 'Build a Java App with CockroachDB' to use:

  - the Java DAO pattern

  - JDBC

  - code for automatically retrying in case of txn retry errors

  - an example of fast bulk insertion using JDBC batching

- Add a 'Recommended Practices' section that includes information about
  IMPORT, recommended batch size, and the JDBC INSERT rewriting flag
rmloveland added a commit that referenced this issue Jun 20, 2019
@rmloveland
Simplify JDBC code sample
a739028 
Fixes #4621, #3578, #4399.

Summary of changes:

- Update 'Build a Java App with CockroachDB' to use:

  - the Java DAO pattern

  - JDBC

  - code for automatically retrying in case of txn retry errors

  - an example of fast bulk insertion using JDBC batching

- Add a 'Recommended Practices' section that includes information about
  IMPORT, recommended batch size, and the JDBC INSERT rewriting flag
rmloveland added a commit that referenced this issue Jun 24, 2019
@rmloveland
Simplify JDBC code sample
13c50fa 
Summary of changes:

- Update 'Build a Java App with CockroachDB' to use:
  - the Java DAO pattern
  - JDBC
  - code for automatically retrying in case of txn retry errors
  - an example of fast bulk insertion using JDBC batching

- Add a 'Recommended Practices' section that includes information about
  IMPORT, recommended batch size, and the JDBC INSERT rewriting flag

Does all of the above for versions 19.1 and 19.2.

Fixes #4621, #3578, #4399.
rmloveland added a commit that referenced this issue Jun 25, 2019
@rmloveland
Simplify JDBC code sample
e69a0d0 
Summary of changes:

- Update 'Build a Java App with CockroachDB' to use:
  - the Java DAO pattern
  - JDBC
  - code for automatically retrying in case of txn retry errors
  - an example of fast bulk insertion using JDBC batching

- Add a 'Recommended Practices' section that includes information about
  IMPORT, recommended batch size, and the JDBC INSERT rewriting flag

Does all of the above for versions 19.1 and 19.2.

Fixes #4621, #3578, #4399.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
O-sales-eng Internal source: Sales Engineering P-1 High priority; must be done this release
Projects
None yet
Milestone
19.2
Development

Successfully merging a pull request may close this issue.

Simplify JDBC code sample cockroachdb/docs
2 participants
@rmloveland @jseldess