Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: run check constraint mutations and validation by schema changer #4362

Closed
jseldess opened this issue Feb 12, 2019 · 3 comments · Fixed by #4612
Closed

sql: run check constraint mutations and validation by schema changer #4362

jseldess opened this issue Feb 12, 2019 · 3 comments · Fixed by #4612
Assignees
@rmloveland
Labels
C-product-change P-1 High priority; must be done this release
Milestone
19.1

Comments

@jseldess
Copy link
Contributor

PR: cockroachdb/cockroach#32504

From release notes:

Table data is now validated against a newly added CHECK constraint asynchronously after the transaction commits. [#32504][#32504] {% comment %}doc{% endcomment %}
@jseldess jseldess added this to the 2.2 milestone Feb 12, 2019
@jseldess
Copy link
Contributor Author

@rmloveland, not sure if/how this affects docs.

@jseldess jseldess added A-sql P-1 High priority; must be done this release labels Feb 13, 2019
@thoszhang
Copy link

thoszhang commented Feb 19, 2019 •
edited
Loading

That PR was reverted and replaced by cockroachdb/cockroach#34301, which does the same thing from a user's perspective.

@jseldess
Copy link
Contributor Author

Thanks, @lucy-zhang. Since we already announced this change in the previous alpha, and it hasn't changed from a user perspective, I'm going to remove it from the 19.1 beta release notes.

@jseldess jseldess modified the milestones: 2.2, 19.1 Feb 25, 2019
rmloveland added a commit that referenced this issue Apr 1, 2019
@rmloveland
Document asynchronous CHECK constraint validation
fe4dd1c 
Fixes #4362.

Summary of changes:

- Update `CHECK` constraint page to note that validation is now
  asynchronous.

- Update 'Add Constraint' page to note that validation is now
  asynchronous, and to give an example of adding a CHECK constraint to a
  column added earlier in the same transaction.
@rmloveland rmloveland mentioned this issue Apr 1, 2019
Merged
rmloveland added a commit that referenced this issue Apr 3, 2019
@rmloveland
Document asynchronous CHECK constraint validation
46151f9 
Fixes #4362.

Summary of changes:

- Update `CHECK` constraint page to note that validation is now
  asynchronous.

- Update 'Add Constraint' page to note that validation is now
  asynchronous, and to give an example of adding a CHECK constraint to a
  column added earlier in the same transaction.
rmloveland added a commit that referenced this issue Apr 15, 2019
@rmloveland
Document asynchronous CHECK constraint validation
6cd3922 
Fixes #4362.

Summary of changes:

- Update `CHECK` constraint page to note that validation is now
  asynchronous.

- Update 'Add Constraint' page to note that validation is now
  asynchronous, and to give an example of adding a CHECK constraint to a
  column added earlier in the same transaction.
rmloveland added a commit that referenced this issue Apr 15, 2019
@rmloveland
Document asynchronous CHECK constraint validation
6da2683 
Fixes #4362.

Summary of changes:

- Update `CHECK` constraint page to note that validation is now
  asynchronous.

- Update 'Add Constraint' page to note that validation is now
  asynchronous, and to give an example of adding a CHECK constraint to a
  column added earlier in the same transaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
C-product-change P-1 High priority; must be done this release
Projects
None yet
Milestone
19.1
Development

Successfully merging a pull request may close this issue.

Document asynchronous CHECK constraint validation cockroachdb/docs
3 participants
@rmloveland @thoszhang @jseldess