Skip to content

v21.1.0-alpha.1

tagged this 02 Dec 05:10
57355: kv/concurrency: bump goroutine stall delay r=nvanbenschoten a=nvanbenschoten

Fixes #57273.

This commit bumps the goroutine stall delay in the TestConcurrencyManagerBasic
framework from 1ms to 5ms. In #57273, we saw a flake due to a goroutine being
classified as stalled when it was actually waiting for a multi-goroutine
chain of events to fire (request exits lockTable, signals lockTable wait-queue,
which is noticed by watchForNotifications, which cancels the pushers context).
This chain of events plus the 1ms wait in the framework led to a flake under
stress roughly every 16k iterations. With this delay bumped to 3ms, I have never
reproduced the flake after over 2M iterations. This PR bumps the delay all the
way up to 5ms to be extra sure. This increases the runtime of all subtests
combined from 1.6s to 3.9s.

Co-authored-by: Nathan VanBenschoten <[email protected]>
Assets 2
Loading