changefeedccl: Do not require rangefeed when running initial scan only. #99494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jayshrivastava
approved these changes
Mar 24, 2023
pkg/BUILD.bazel
Outdated
| "-integration", | ||
| "ccl_test", |
There was a problem hiding this comment.
I don't understand this... just keeps insisting on rearranging it....
There was a problem hiding this comment.
Just running ./dev/lint
Do you want this reverted, @jayshrivastava ?
miretskiy
force-pushed
the
initialscan
branch
3 times, most recently
from
a595c63 to
91f3bdc
Compare
Fixes cockroachdb#99470 Release note: None
|
bors r+ |
|
bors r+ |
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99470
Release note: None