[dnm] kvserver: more logging for #100096 #99482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbg
requested review from
srosenberg and
renatolabs
and removed request for
a team
|
This change is |
tbg
changed the title
tbg
force-pushed
the
deflake-copyfrom-99464
branch
from
86d55fb to
12ec34b
Compare
cucaroach
suggested changes
Mar 24, 2023
tbg
force-pushed
the
deflake-copyfrom-99464
branch
from
12ec34b to
e7e0b6d
Compare
When stressing a roachtest, it can be helpful to have the artifacts collected even when the test passes, for example to check for markers of an interesting issue[^1] in the logs. [^1]: cockroachdb#99464 (comment) Epic: none Release note: None
tbg
force-pushed
the
deflake-copyfrom-99464
branch
from
e7e0b6d to
b9366f9
Compare
See cockroachdb#99464 (comment). Epic: none Release note: None
tbg
force-pushed
the
deflake-copyfrom-99464
branch
from
b9366f9 to
4567373
Compare
tbg
force-pushed
the
deflake-copyfrom-99464
branch
3 times, most recently
from
e525270 to
9443071
Compare
Epic: none Release note: None
tbg
force-pushed
the
deflake-copyfrom-99464
branch
from
9443071 to
4a7a53b
Compare
tbg
force-pushed
the
deflake-copyfrom-99464
branch
from
653a813 to
88923df
Compare
tbg
changed the title
The bytes printed after "wrote" where the append bytes only, this was confusing. Consolidate. Also, no need to print whether it's sync or non-blocking-sync again because we already printed that in the timing section. Found in cockroachdb#100096. Epic: none Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #99464 (comment) and #100096.
Run via gceworker:
Then look at logs from artifacts.
Epic: none
Release note: None