Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: simplify V23_1ExternalConnectionsTableHasOwnerIDColumn gating #98739

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

andyyang890
Copy link
Collaborator

@andyyang890 andyyang890 commented Mar 16, 2023

Informs #87079

Release note: None

@blathers-crl
Copy link

blathers-crl bot commented Mar 16, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 marked this pull request as ready for review March 16, 2023 04:50
@andyyang890 andyyang890 requested a review from a team as a code owner March 16, 2023 04:50
@andyyang890 andyyang890 requested review from a team, benbardin, rafiss and adityamaru and removed request for a team March 16, 2023 04:50
Copy link
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=adityamaru

@craig
Copy link
Contributor

craig bot commented Mar 17, 2023

Build failed:

@andyyang890
Copy link
Collaborator Author

bors retry

@craig
Copy link
Contributor

craig bot commented Mar 17, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 18, 2023

Build succeeded:

@craig craig bot merged commit c86687c into cockroachdb:master Mar 18, 2023
@andyyang890 andyyang890 deleted the simplify_externalconn_gating branch March 18, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants