Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump cockroach-go version #98383

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 10, 2023

This includes two changes:

  • The testserver gracefully shuts down, and instead of abruptly.
  • The TMPDIR environment variable is respected, which should allow us to
    see testserver logs in CI artifacts now.

informs #95247
Release note: None

@rafiss rafiss requested a review from renatolabs March 10, 2023 17:02
@rafiss rafiss requested a review from a team as a code owner March 10, 2023 17:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss changed the title go.mod: bump cockroach-go version logictest: bump cockroach-go version and copy logs before cleanup Mar 10, 2023
This includes two changes:

- The testserver gracefully shuts down, and instead of abruptly.
- The TMPDIR environment variable is respected, which should allow us to
  see testserver logs in CI artifacts now.

Release note: None
@rafiss rafiss force-pushed the preserve-logs-mixed-version-test branch from d3186bb to fcbc1b9 Compare March 10, 2023 18:15
@rafiss rafiss changed the title logictest: bump cockroach-go version and copy logs before cleanup go.mod: bump cockroach-go version Mar 10, 2023
@rafiss
Copy link
Collaborator Author

rafiss commented Mar 10, 2023

tftrs!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 10, 2023

Build succeeded:

@craig craig bot merged commit 1a58583 into cockroachdb:master Mar 10, 2023
@rafiss rafiss deleted the preserve-logs-mixed-version-test branch March 13, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants