builtins: fix crdb_internal.hide_sql_constants array overload #97853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
THardy98
reviewed
Mar 1, 2023
There was a problem hiding this comment.
Is it intended to work this way, where we swallow the error on statements that can't be parsed with an empty?
Just wondering what the intuition here is.
Reviewable status:
complete! 0 of 0 LGTMs obtained
|
Yes, I just noticed I messed up the return here for this overload, should only be relevant for testing right now. |
Previously, erroring on parsing a stmt provided in one of the array elements to crdb_internal.hide_sql_constants would result in an error. This commit ensures that the empty string is returned for an unparseable stmt. Epic: none Release note: None
xinhaoz
force-pushed
the
builtins-array-fix
branch
from
7b7f3e6 to
17f635d
Compare
THardy98
approved these changes
Mar 1, 2023
|
bors r+ |
|
Build succeeded: |
This was referenced Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, erroring on parsing a stmt provided in one of the array elements to crdb_internal.hide_sql_constants would result in an error. This commit ensures that the empty string is returned for an unparseable stmt.
Epic: none
Release note: None