Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: physicalplan: don't combine render nodes into one processor #97593

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 23, 2023

Backport 1/1 commits from #97554 on behalf of @DrewKimball.

/cc @cockroachdb/release


During planning for a render node, the physical planning logic checks whether the last created processor rendered its own expressions, adds its render expressions to the processor if not. The check is necessary to handle the case when expressions in a parent render reference those from a child render.

However, render nodes also handle projecting input columns: both removing them and reordering them. Correct planning of the processors depends on the columns at each step being in a particular order. Since physical planning didn't check whether the existing processor projected its columns in some way, the parent render could be combined with its child. This could lead to panics in the parent render expressions when the columns weren't projected as expected. This patch fixes the issue by adding the projection check before allowing the render planning code to add to the previous processor.

Fixes #95633

Release note (bug fix): Fixed a rare bug existing since before 22.1 that
could cause a projected expression to replace column references with the
wrong values.


Release justification: low-risk for internal error during distsql planning

@blathers-crl blathers-crl bot requested a review from a team as a code owner February 23, 2023 21:33
@blathers-crl blathers-crl bot requested a review from rytaft February 23, 2023 21:33
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-97554 branch from eb4dee5 to 7369f12 Compare February 23, 2023 21:33
@blathers-crl blathers-crl bot requested a review from yuzefovich February 23, 2023 21:33
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 23, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 23, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rytaft)

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@DrewKimball DrewKimball force-pushed the blathers/backport-release-22.2-97554 branch from 7369f12 to 29f609b Compare April 3, 2023 19:54
During planning for a render node, the physical planning logic checks
whether the last created processor rendered its own expressions, adds its
render expressions to the processor if not. The check is necessary to handle
the case when expressions in a parent render reference those from a child
render.

However, render nodes also handle projecting input columns: both removing
them and reordering them. Correct planning of the processors depends on the
columns at each step being in a particular order. Since physical planning
didn't check whether the existing processor projected its columns in some
way, the parent render could be combined with its child. This could lead
to panics in the parent render expressions when the columns weren't projected
as expected. This patch fixes the issue by adding the projection check
before allowing the render planning code to add to the previous processor.

Fixes #95633

Release note (bug fix): Fixed a rare bug existing since before 22.1 that
could cause a projected expression to replace column references with the
wrong values.
@DrewKimball DrewKimball force-pushed the blathers/backport-release-22.2-97554 branch from 29f609b to d074c11 Compare April 3, 2023 20:05
@DrewKimball
Copy link
Collaborator

TFYR

@DrewKimball DrewKimball merged commit dfffdf1 into release-22.2 Apr 3, 2023
@DrewKimball DrewKimball deleted the blathers/backport-release-22.2-97554 branch April 3, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants